Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: use GNUInstallDirs to normalize libexecdir #1088

Closed
wants to merge 1 commit into from

Conversation

trws
Copy link
Member

@trws trws commented Sep 29, 2023

fixes: #1083
Problem: install using wrong libexec directory

Solution: use the libexec directory provided by GNUInstallDirs, add flux intermediary

Problem: install using wrong libexec directory

Solution: use the libexec directory provided by GNUInstallDirs
@trws trws requested a review from grondo September 29, 2023 08:18
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #1088 (c3248d2) into master (4e3afdd) will decrease coverage by 0.1%.
The diff coverage is n/a.

❗ Current head c3248d2 differs from pull request most recent head 7d34b0b. Consider uploading reports for the commit 7d34b0b to get more accurate results

@@           Coverage Diff            @@
##           master   #1088     +/-   ##
========================================
- Coverage    71.7%   71.7%   -0.1%     
========================================
  Files          89      89             
  Lines       11665   11665             
========================================
- Hits         8374    8371      -3     
- Misses       3291    3294      +3     

see 1 file with indirect coverage changes

@grondo
Copy link
Contributor

grondo commented Oct 3, 2023

I think this was superseded by a fix in the PR that resurrected make deb (#1082). Closing this one (feel free to reopen if necessary). Thanks for all your help on the build system @trws!

@grondo grondo closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: cmake installs to wrong libexecdir
2 participants