Golang bindings: third time is the charm? #1081
Conversation
vsoch
force-pushed
the
third-time-the-charm
branch
from
c7f2fd6 to
e1f5d98
Compare
Go clients need to call REAPI CLI functions. Add Go bindings for REAPI CLI for resource module initialization, destruction, match allocate, cancel, and other common functions.
Go clients need to call REAPI module functions. Add Go bindings for REAPI module for resource module initialization, destruction, match allocate, cancel, and other common functions.
Problem: the REAPI module assumes the resource module is already initialized but does not open a handle to it. Open a handle to make calls with a resource module instance.
Problem: the Golang bindings need to be tested as part of the Fluxion testsuite. Add a main Go test to initialize the resource module and output strings for comparison with expected outputs.
Problem: the main test file must be built as part of the `make check` tests. Configure autotools to build main.go for sharness tests.
Problem: the test matrix does not have an image with Go installed. Create a new Docker image which installs Go and adds `go` to `PATH`. Add the image and additional tests to the CI test matrix.
Problem: the Fluxion sharness tests need to test the Golang bindings. Add a basic sharness test and expected outputs.
Problem: Go bindings can be more friendly to Go developers Solution: This includes docstring changes, the main module path to be under flux-framework, returning Go error instead of int, and updating tests to return nil (no error) instead of 0. The module path is fixed from a development variant to a flux-framework one. Finally, it fixes the Go bindings to use a struct instead of passing around a ctx variable. Our goal with these final changes to the Go module is to make the code more friendly to future go developers. Signed-off-by: vsoch <[email protected]>
Problem: the new cmake build system needs to compile go tests for bindings Solution: use add_custom_command to do a build of the test. Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
third-time-the-charm
branch
from
e1f5d98 to
1d7635b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1081 +/- ##
========================================
Coverage ? 71.6%
========================================
Files ? 89
Lines ? 11569
Branches ? 0
========================================
Hits ? 8289
Misses ? 3280
Partials ? 0 |
|
🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 📗 🟢 💚 🥗 🍵 🟩 🍏 Dear deity that I don't believe in. Or maybe just the light up dinosaur on my desk that I talk to sometimes. Please let this PR be good. I promise... well not much. Maybe I will share more avocados. Please let this be the third time is the charm, really really, this time! 🙏 -v |
|
Closing here because we want to merge into the PR with the correct discussion, #1062, and mergify is having a hot minute looking at the equivalent commits. |
Follow up from #1062.
I don't know how to do the interactive rebase so I did it manually, hopefully didn't mess something up.