testsuite: adjust expectations of recovery in rv1_nosched mode #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: t1008-recovery-none.t expects the job manager to abort the scheduler if a job fails to re-allocate resources during the hello handshake, but this behavior will change soon. Drop this test. The behavior it is looking for will either be addressed by a true fix to flux-framework#991 or the workaround proposed in flux-framework/flux-core#4894.
Problem: t1007-recovery-full.t cancels each test job then runs the cleanup_active_jobs helper function, which does the same thing. Drop the explicit cleanup from the test.
Problem: there is no test coverage for module reload with running jobs and rv1_nosched. Add test proposed by @grondo in flux-framework#991, expecting failure for now. The test fails before and after the work-around proposed in flux-framework/flux-core#4894 because it checks for both: - qmanager reload fails (fails before the work-around) - job resources remain allocated (fails after the work-around) Increase the broker stderr log verbosity so the fatal job exceptions generated by the work-around at LOG_INFO level are visible when the test is run with -v.
grondo
approved these changes
Jan 28, 2023
garlick
added
the
merge-when-passing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1000 +/- ##
========================================
- Coverage 74.1% 74.1% -0.1%
========================================
Files 78 78
Lines 9327 9327
========================================
- Hits 6915 6912 -3
- Misses 2412 2415 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters testing a bit in preparation for a workaround and ultimately a proper fix for #991.
The
t1008-recovery-none.tsharness test is dropped since it really just contains one recovery test that expects things to fail as they have been. Replace that with a new expected-failure test int1007-recovery-fullthat is a slightly modified version of the one proposed by @grondo in #991. This test should fail as expected before and after the workaround proposed in flux-framework/flux-core#4894, and when we have a proper fix for #991, it can be flipped to expect success.After this is merged, the failing sched CI test in flux-framework/flux-core#4894 should start working.