-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all code that uses wreck and other removed flux-core interfaces #437
Comments
My vote is for Option 1. I think there is value in keeping flux-sched master building against flux-core@master. If we tie flux-sched to v0.11.0 now, I'm afraid that all the changes to become compatible with flux-core@master will end up in one massive PR rather than several smaller, easier to digest PRs. I think Option 1 would also make it easier to test out the new job manager / scheduler interfaces. @dongahn, what are your thoughts? |
Thanks @SteVwonder. Another benefit of option 1 is that flux-sched repo will be managed the same as flux-core, and we can trigger option 2 when needed. That being said, it will be a fair amount of work to make flux-sched work with flux-core + flux-framework/flux-core#1988. |
Remove code and interfaces dependent on upstream flux-core wreck and Lua interfaces that have since been removed. Includes removal of rdl, sched, resrc and associated tests and scripts. Fixes flux-framework#437
If we were to do this, we might as well do this now. Option 1. All-in will make our effort more focused. It will take substantial effort and we need to make sure we have enough of @SteVwonder and my time going into this. |
I have a very rough cut started to make sure the work I've done in flux-framework/flux-core#1988 doesn't remove something sched may require. I'll link that here once it is complete. It may give you a head start. |
Remove code and interfaces dependent on upstream flux-core wreck and Lua interfaces that have since been removed. Includes removal of rdl, sched, resrc and associated tests and scripts. Fixes flux-framework#437
Remove code and interfaces dependent on upstream flux-core wreck and Lua interfaces that have since been removed. Includes removal of rdl, sched, resrc and associated tests and scripts. Fixes flux-framework#437
See https://github.com/grondo/flux-sched/tree/kill-wreck -- this version removes rdl, resrc and the simulator, along with associated tests, commands and scripts. It passes Travis-CI, but I'm not sure if I removed too much. Edit: I'm happy to open this branch as a PR, but I wanted approval first -- this first pass may have been too heavy a hand. |
@SteVwonder @dongahn, did either of you have a chance to review my branch posted above? Before we can merge the PR in flux-core that removes the old execution system, we wanted to make sure flux-sched@master can move forward. |
Yeah. It looks fine to me. The @dongahn, thoughts? |
Do you want me to just open a PR? I wasn't sure if either you or @dongahn wanted to do that instead, using my branch perhaps as a reference.. |
If you are offering to open a PR, I'm not going to turn you down 😆 |
LGTM as well. BTW, what this means is we don't have a scheduler which works end to end. So we will want to make it a priority to catch up the flux-core's new execution system. Some of the major items:
Although there are a lot of work to do, the beauty of this is we get to use our scheduler as early as possible :-) |
There is a PR pending in flux-core: flux-framework/flux-core#1988 which will remove the wreck execution system and many other interfaces and APIs that have been deprecated for awhile.
Before this is merged, perhaps, this will require a strategy for flux-sched, a few ideas that come to mind are:
The text was updated successfully, but these errors were encountered: