-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conversion to cmake dropped make deb
#1072
Comments
Oh I guess CPack has a deb generator. But this would (I assume) require moving all the stuff from the debian directory into CMakeLists.txt. |
grondo
added a commit
to grondo/flux-sched
that referenced
this issue
Sep 28, 2023
Problem: The 'make deb' target was dropped in the conversion to cmake, but having an easy way to build test .deb packages has become an essential component of testing. Add a custom 'deb' target to CmakeLists.txt. Since this target requires 'make dist', add a 'dist' custom target as well. Some versions of git do not support the `--add-virtual-file` option, so instead of using that to add the flux-sched.ver file to the archive, just create the file, add it, and subsequently remove it. Fixes flux-framework#1072
grondo
added a commit
to grondo/flux-sched
that referenced
this issue
Sep 28, 2023
Problem: The 'make deb' target was dropped in the conversion to cmake, but having an easy way to build test .deb packages has become an essential component of testing. Add a custom 'deb' target to CmakeLists.txt. Since this target requires 'make dist', add a 'dist' custom target as well. Some versions of git do not support the `--add-virtual-file` option, so instead of using that to add the flux-sched.ver file to the archive, just create the file, add it, and subsequently remove it. Fixes flux-framework#1072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With autotools we had a simple
make deb
target that essentially just runsscripts/debbuild.sh
.However
debbuild.sh
depends onmake dist
, which was also dropped in the conversion to cmake.I tried copying the following from the
distcheck
target to bring back amake dist
:But the
--add-virtual-file
option togit archive
doesn't seem to exist ingit 2.30
. A bit confused on what to try next,cmake
doesn't have a concept of creating a distribution tarball as required by most packaging software?The text was updated successfully, but these errors were encountered: