Skip to content

Commit

Permalink
Fix broken && chains in t4014
Browse files Browse the repository at this point in the history
Problem: fedora40 CI fails on t4014 due to """
  error: bug in the test script: broken &&-chain:
      load_feasibility
      flux dmesg -c | grep -q "File exists"
"""

Add && between successive statements in t4014.
  • Loading branch information
jacobtkeio committed Sep 29, 2024
1 parent e57c11a commit 5c573ad
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions t/t4014-match-feasibility.t
Original file line number Diff line number Diff line change
Expand Up @@ -21,28 +21,29 @@ test_debug '
'

test_expect_success 'loading feasibility module over sched-simple fails' '
load_feasibility
load_feasibility &&
flux dmesg -c | grep -q "File exists"
'

test_expect_success 'removing sched-simple works' '
flux module remove sched-simple
flux module remove sched-simple &&
flux dmesg -c | grep -q "rmmod sched-simple"
'

test_expect_success 'loading feasibility module before resource fails' '
load_feasibility
load_feasibility &&
flux dmesg -c | grep -q "Function not implemented"
'

test_expect_success 'loading resource module with a tiny machine config works' '
load_resource load-file=${grug} load-format=grug \
prune-filters=ALL:core subsystems=containment policy=high
prune-filters=ALL:core subsystems=containment policy=high &&
test -z "$(flux dmesg -c | grep -q err)"
'

test_expect_success 'loading feasibility module with a tiny machine config works' '
load_feasibility load-file=${grug} load-format=grug \
prune-filters=ALL:core subsystems=containment policy=high
prune-filters=ALL:core subsystems=containment policy=high &&
test -z "$(flux dmesg -c | grep -q err)"
'

Expand Down Expand Up @@ -72,7 +73,7 @@ test_expect_success 'jobspec is still satisfiable even when no available resourc
'

test_expect_success 'removing load-file feasibility module works' '
remove_feasibility
remove_feasibility &&
test -z "$(flux dmesg -c | grep -q err)"
'

Expand All @@ -89,12 +90,12 @@ test_expect_success 'removing resource module works' '
'

test_expect_success 'loading non-load-file resource module works' '
load_resource
load_resource &&
test -z "$(flux dmesg -c | grep -q err)"
'

test_expect_success 'loading feasibility from non-load-file resource module works' '
load_feasibility
load_feasibility &&
test -z "$(flux dmesg -c | grep -q err)"
'

Expand Down

0 comments on commit 5c573ad

Please sign in to comment.