Skip to content

Commit

Permalink
build: do not install libresource.so
Browse files Browse the repository at this point in the history
Problem: libresource.so was previously a convenience library, but is
now installed by default. However, it has a generic name that could
easily become confusing, and is named simply `libresource.so`, which
doesn't follow standard shared library naming conventions.

Make libresource a static convenience library instead and do
not install it.  The library should be renamed something like
`libfluxion-resoruce.so` and possibly be versioned with an soname if
installed in the future.

Fixes #1093
  • Loading branch information
grondo committed Oct 2, 2023
1 parent b29177b commit 0ea1aae
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions resource/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ set(RESOURCE_HEADERS
store/resource_graph_store.hpp
)

add_library(resource SHARED
add_library(resource STATIC
policies/dfu_match_locality.cpp
policies/dfu_match_var_aware.cpp
policies/dfu_match_policy_factory.cpp
Expand Down Expand Up @@ -87,8 +87,6 @@ target_link_libraries(resource PUBLIC
jobspec_conv
Boost::filesystem
)
install(TARGETS resource
LIBRARY)

add_subdirectory(modules)
add_subdirectory(reapi)
Expand Down

0 comments on commit 0ea1aae

Please sign in to comment.