remove use of deprecated commands and functions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: flux_job_list(3) has been deprecated, but it is used by the pam_flux PAM module. Drop flux_job_list() in favor of using flux_rpc() directly.
Problem: On error in flux_rpc_pack(3), a future may be leaked. Destroy the future in the error path.
Problem: flux-mini(1) has been deprecated, but is still in use in the pam-flux testsuite. Replace use of flux-mini(1) with flux-submit(1).
grondo
added
the
merge-when-passing
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the flux PAM module away from the deprecated
flux_job_list(3)funciton andflux-mini(1)command.