Add tests for Issue 495 #996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just thought of a few more test to add, hold off on merge for now |
|
added a couple of more tests |
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
==========================================
- Coverage 76.17% 76.16% -0.01%
==========================================
Files 153 153
Lines 26545 26545
==========================================
- Hits 20220 20219 -1
- Misses 6325 6326 +1
Continue to review full report at Codecov.
|
Add remote EPROTO tests for flux_rpcf and flux_rpcf_multi
Add tests to check for EPROTO locally, when a user incorrectly assumes there is no payload (when there is one) or when a user incorrectly assumes a payload (when there isn't one).
|
closing, will splilt up into future PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying to wrap my head around issue #495, decided to add some tests to start, as I don't believe the original issue was directly or indirectly tested. Added some tests via
flux_rpc_get()andflux_rpc_getf(). A few minor test additions & misc fixes as well.