Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for disabling commit-merge in kvs + additional minor cleanup patches #979

Merged
merged 5 commits into from
Feb 16, 2017

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Feb 10, 2017

Test for disabling commit-merge in kvs per discussion in issue #813

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 76.193% when pulling ce06972 on chu11:issue813-unittest into edc914e on flux-framework:master.

@codecov-io
Copy link

codecov-io commented Feb 10, 2017

Codecov Report

Merging #979 into master will increase coverage by 0.01%.

@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage    75.9%   75.91%   +0.01%     
==========================================
  Files         152      152              
  Lines       25937    25937              
==========================================
+ Hits        19688    19691       +3     
+ Misses       6249     6246       -3
Impacted Files Coverage Δ
src/broker/module.c 78.82% <100%> (ø)
src/broker/modservice.c 63.15% <ø> (-0.88%)
src/common/libutil/veb.c 98.29% <ø> (-0.57%)
src/common/libflux/message.c 83.44% <ø> (-0.14%)
src/common/libflux/dispatch.c 82.71% <ø> (+0.28%)
src/modules/kvs/kvs.c 80.46% <ø> (+0.36%)
src/modules/kvs/waitqueue.c 88.17% <ø> (+2.15%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc914e...ce06972. Read the comment docs.

@garlick
Copy link
Member

garlick commented Feb 16, 2017

Sounds good. Is this ready to go?

@chu11
Copy link
Member Author

chu11 commented Feb 16, 2017

yup!

@garlick garlick merged commit 0889e59 into flux-framework:master Feb 16, 2017
@grondo grondo mentioned this pull request Mar 28, 2017
@chu11 chu11 deleted the issue813-unittest branch June 5, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants