resource-hwloc: put HostName in by_rank directory

[grondo]

Had this commit sitting on a branch for a while, getting stale. It might be useful so I'm proposing it as a PR for discussion.

Adds a resource.hwloc.by_rank..HostName key containing the hwloc-provided hostname for the current rank.

[codecov-io]

Current coverage is 72.21% (diff: 80.00%)

Merging #892 into master will increase coverage by <.01%

@@             master       #892   diff @@
==========================================
  Files           157        157          
  Lines         27007      27012     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          19500      19506     +6   
+ Misses         7507       7506     -1   
  Partials          0          0          

Diff Coverage	File Path
•••••••• 80%	src/modules/resource-hwloc/resource.c

Powered by Codecov. Last update a06cf00...b096018

[coveralls]

Coverage increased (+0.03%) to 75.839% when pulling 4a28f45 on grondo:hwloc-byrank-hostname into a06cf00 on flux-framework:master.

[lipari]

Seems like a fine addition to me!

[garlick]

Referencing #866 and #855 where the motivation for this was discussed.

One thought: do we want to support the reverse lookup, hostname to nodeset? I guess that would greatly complicate this simple PR so I dumped a couple thoughts into #893.

This seems good to me, and I did give it a test and it worked.

[garlick]

Maybe a little test would be good actually, like

diff --git a/t/t2005-hwloc-basic.t b/t/t2005-hwloc-basic.t
index 15577f6..ee14d59 100755
--- a/t/t2005-hwloc-basic.t
+++ b/t/t2005-hwloc-basic.t
@@ -116,4 +116,10 @@ test_expect_success 'hwloc: reload fails on invalid rank' '
     grep "No route to host" stderr
 '

+test_expect_success 'hwloc: HostName is populated in by_rank' '
+    HW_HOST=$(flux kvs get resource.hwloc.by_rank.0.HostName) &&
+    REAL_HOST=$(hostname) &&
+    test x"$HW_HOST" = x"$REAL_HOST"
+'
+
 test_done

[chu11]

Seems like a good idea to me. Minimally, getting hostnames out of the kvs with this is better than the xml parsing hack I originally did in #864.

[grondo]

Maybe a little test would be good actually, like

Great idea, I'll add your enhancement to this PR or you could just push it

[garlick]

Cool, that worked!

[coveralls]

Coverage increased (+0.008%) to 75.813% when pulling b096018 on grondo:hwloc-byrank-hostname into a06cf00 on flux-framework:master.

[garlick]

Here's where I would push the button, but I should probably recuse myself because I pushed a commit to this PR. @chu11 want to do the honors?

[grondo]

Thanks @garlick! (At home with a sick kid so not getting much work done
today)

On Nov 3, 2016 12:49 PM, "Jim Garlick" [email protected] wrote:

Cool, that worked!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#892 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtSUtpZk_GtGTx_IFUmKxMfiLRIq4iBks5q6jq6gaJpZM4KoomP
.

[chu11]

@garlick sure thing. everything LGTM too.