flux-kvs: improve eventlog error messages #6531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
approved these changes
Dec 20, 2024
src/cmd/flux-kvs.c
Outdated
| if (!(a = eventlog_decode (s))) | ||
| if (!(a = eventlog_decode (s))) { | ||
| if (errno == EINVAL) { | ||
| log_msg ("cannot decode improperly formatted eventlog"); |
| @@ -2135,8 +2140,13 @@ void eventlog_wait_event_continuation (flux_future_t *f, void *arg) | |||
| log_err_exit ("flux_kvs_lookup_get"); | |||
| } | |||
|
|
|||
| if (!(a = eventlog_decode (s))) | |||
| if (!(a = eventlog_decode (s))) { | |||
Problem: When an improperly formatted eventlog is input into eventlog commands, a non-useful error message is output. Output a better error message.
Problem: The flux kvs eventlog commands don't have coverage for improperly formatted eventlogs. Add some coverage to t1008-kvs-eventlog.t.
chu11
force-pushed
the
flux_kvs_better_errormsg
branch
from
2cb18ac to
8d7ad52
Compare
|
thanks, tweaked per comment above, setting MWP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When an improperly formatted eventlog is input into eventlog commands, a non-useful error message is output.
Output a better error message.