libschedutil: use preprocessor symbols for flags #6520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
force-pushed
the
schedutil_no_enum
branch
from
895d490 to
323e0b8
Compare
Problem: it's laborious to test flux-core for the existence of schedutil flags because they are anonymous enums. Convert to preprocessor symbols that can be easily checked with an #ifdef in the scheduler.
garlick
force-pushed
the
schedutil_no_enum
branch
from
323e0b8 to
69b0247
Compare
|
Thanks! I'll set MWP. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6520 +/- ##
==========================================
- Coverage 83.62% 83.61% -0.02%
==========================================
Files 522 522
Lines 87734 87734
==========================================
- Hits 73368 73356 -12
- Misses 14366 14378 +12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: its laborious to test flux-core for the existence of schedutil flags because they are anonymous enums.
Convert to preprocessor symbols that can be easily checked with an #ifdef in the scheduler.