-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor man page improvements #6519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just those commit message nits i found
@@ -440,6 +440,13 @@ plugins include: | |||
takes place on all the job's nodes if the scope is local, versus only the | |||
first node of the job if the scope is global. | |||
|
|||
.. warning:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message s/beter/better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message s/drived/drifted/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, good catch!
c60192c
to
7a58df2
Compare
Huh, this unit test failed on el8. I'll run it again but it's an odd one to fail.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great changes here!
of higher level commands such as :man1:`flux-submit`. | ||
must also be set for the stream. | ||
|
||
See also: :option:`flux-submit --output`, :option:`flux-submit --error`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this was smart!
Thanks guys - I'll set MWP |
Problem: a warning box intended to clarify a point about stage-in file paths has drifted away from the shell stage-in options. Move warning box back to its original location.
Problem: users may be unaware of the nicer flux-submit shorthands for shell options when perusing flux-shell(1). Add some explicit linked references and normalize the form of the references that already exist.
Problem: the environment available to prolog, epilog, and housekeeping scripts is not documented in the environment man page. Add a section.
7a58df2
to
95ed4fd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6519 +/- ##
==========================================
- Coverage 83.66% 83.61% -0.06%
==========================================
Files 522 522
Lines 87734 87734
==========================================
- Hits 73401 73356 -45
- Misses 14333 14378 +45 |
Here are a few fixes to man page deficiencies that I noticed.