build macos with homebrew lua that is not deprecated #6509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: homebrew has apparently deprecated lua5.3 on macos as CI builds now fail with "[email protected] has been disabled! It will be disabled on 2024-12-14". Install the current lua package on macos instead (5.4.7 as of now).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6509 +/- ##
==========================================
- Coverage 83.63% 83.60% -0.04%
==========================================
Files 525 525
Lines 87693 87693
==========================================
- Hits 73342 73313 -29
- Misses 14351 14380 +29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: macos ci builds are failing (that didn't take long!) because apparently the lua I chose was about to be deprecated, and now is.
This fixes that.