support specification of file permissions in --add-file submission option
#6505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: If perms is passed as None in Jobspec.add_file(), then the default of 0600 is overridden. It would be better to use the default in this case. Set the default value of perms to None in the function arguments, and if perms is None use the default of 0o600.
Problem: A file added via the cli submission --add-file=NAME=DATA option always gets the default permissions of 0600. Allow the file name to contain a colon followed by permissions, e.g. --add-file=test:700="sleep 0\n"
Problem: The --add-file description in common/job-other-options.rst doesn't include the ability to force file permissions. Update the documentation.
Problem: No tests in the testsuite ensure that file permissions may be specified in the submission cli `--add-file` option. Add a couple test to t2710-python-cli-submit.t.
garlick
approved these changes
Dec 13, 2024
|
I did look for something, but only found solutions for parsing the ls output style e.g. |
|
Thanks I've set MWP. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6505 +/- ##
==========================================
- Coverage 83.64% 83.63% -0.02%
==========================================
Files 525 525
Lines 87684 87693 +9
==========================================
- Hits 73345 73341 -4
- Misses 14339 14352 +13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying file permissions in the
--add-fileoption in Flux submission command. (Presently, all files added with content directly provided on the command like get the default permissions of 0600)Example: