Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize code formatting #6481

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

garlick
Copy link
Member

@garlick garlick commented Dec 5, 2024

Problem: some older code violates RFC 7 whitespace guidelines.

Break long parameter lists to one per line.

This chunk of whitespace cleanup was peeled off of #6467

Problem: some older code violates RFC 7 whitespace guidelines.

Break long parameter lists to one per line.
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@mergify mergify bot merged commit 2e7b064 into flux-framework:master Dec 5, 2024
34 checks passed
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (0cfb291) to head (a288986).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6481      +/-   ##
==========================================
- Coverage   83.58%   83.57%   -0.01%     
==========================================
  Files         524      524              
  Lines       87611    87617       +6     
==========================================
+ Hits        73227    73229       +2     
- Misses      14384    14388       +4     
Files with missing lines Coverage Δ
src/common/libflux/conf.c 85.56% <100.00%> (ø)
src/common/libflux/event.c 77.66% <100.00%> (ø)
src/common/libflux/fripp.c 88.25% <100.00%> (+0.04%) ⬆️
src/common/libflux/future.c 88.77% <100.00%> (ø)
src/common/libflux/message.c 91.91% <ø> (ø)
src/common/libflux/msg_handler.c 86.54% <ø> (ø)
src/common/libflux/plugin.c 92.50% <100.00%> (+0.02%) ⬆️
src/common/libflux/request.c 84.76% <100.00%> (ø)
src/common/libflux/service.c 60.00% <100.00%> (ø)
src/common/libkvs/kvs_dir.c 88.88% <100.00%> (+0.33%) ⬆️
... and 1 more

... and 9 files with indirect coverage changes

@garlick garlick deleted the cosmetic_cleanup branch December 5, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants