libsubprocess: check bufsize is > 0 #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A test in libsubprocess outputs the wrong function name in its test description. Fix the function name in the test.
Problem: The service name used when setting up a subprocess server is configurable. However, most of the error messages assume the service name is "rexec". This can lead to log messages pointing users to the wrong RPC target. Store the service name in the subprocess server context and output the appropriate RPC target in error messages.
Problem: A channel bufsize setting of 0 is technically possible, which should not be allowed. Check for bufsize > 0. Add unit test.
chu11
force-pushed
the
libsubprocess_bufsize_zero
branch
from
15d60a1 to
0482fd6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6365 +/- ##
==========================================
- Coverage 83.28% 83.27% -0.01%
==========================================
Files 524 524
Lines 86224 86230 +6
==========================================
Hits 71812 71812
- Misses 14412 14418 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peeling off some independent cleanups/fixups from #6353