Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutdown: unload perilog plugin during shutdown #5871

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

garlick
Copy link
Member

@garlick garlick commented Apr 9, 2024

Problem: when flux is shutting down and canceling running jobs, the epilog can greatly extend the shutdown time.

Unload the perilog plugin as part of the cleanup tasks so that canceled jobs can complete quickly in the shutdown case.

Note: @grondo's good IMHO idea! This was peeled off of #5860 because it seems like it might be a good candidate for a point release, whereas #5860 is too big of a change for that.

Problem: when flux is shutting down and canceling running
jobs, the epilog can greatly extend the shutdown time.

Unload the perilog plugin as part of the cleanup tasks so that
canceled jobs can complete quickly in the shutdown case.
@garlick
Copy link
Member Author

garlick commented Apr 9, 2024

Restarted the fedora38 builder after this failure:

2024-04-09T15:34:00.6879695Z make  check-TESTS
2024-04-09T15:34:00.7586099Z                 test_pty.t:  PASS: N=83  PASS=83  FAIL=0 SKIP=0 XPASS=0 XFAIL=0
2024-04-09T15:34:00.9682855Z            test_terminus.t:  SKIP: N=0   PASS=0   FAIL=0 SKIP=0 XPASS=0 XFAIL=0
2024-04-09T15:34:00.9684195Z ERROR: test_terminus.t - missing test plan
2024-04-09T15:34:00.9685258Z ERROR: test_terminus.t - exited with status 139 (terminated by signal 11?)

Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garlick
Copy link
Member Author

garlick commented Apr 9, 2024

Thanks! Setting MWP

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Merging #5871 (77cf439) into master (3464b31) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5871      +/-   ##
==========================================
+ Coverage   83.27%   83.30%   +0.02%     
==========================================
  Files         514      514              
  Lines       82756    82756              
==========================================
+ Hits        68915    68936      +21     
+ Misses      13841    13820      -21     

see 14 files with indirect coverage changes

@mergify mergify bot merged commit 8ffa238 into flux-framework:master Apr 9, 2024
35 checks passed
@garlick garlick deleted the shutdown_epilog branch April 9, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants