job-manager: include R in sched.free request #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
added a commit
to garlick/flux-rfc
that referenced
this pull request
Mar 11, 2024
Problem: flux-framework/flux-core#5783 adds R to the sched.free request to avoid an extra lookup. Add R to the sched.free request payload definition in RFC 27.
Problem: R has to be looked up from the KVS in the sched.free request handler, but now that the job manager caches R, this is an unnecessary extra step. Add R to the sched.free request payload. Note that the `R.scheduling` key is not included. The current design of Fluxion in which `R.scheduling` may contain a voluminous JGF object made caching this part of R impractical. Change libschedutil so that - the sched.free message handler never looks up R in the kvs - the free callback always sets its `R` argument to NULL - the SCHEDUTIL_FREE_NOLOOKUP flag is a no-op Update sched-simple's free callback to unpack R from the message instead of decoding the `R` arugment. Note that Fluxion sets SCHEDUTIL_FREE_NOLOOKUP so it already expects the free callback's R argument to be NULL. Although this change increases the size of sched.free payloads with data that Fluxion currently does not use, the ranks in R will be required by Fluxion in the future to identify resource subsets for partial release (flux-framework/flux-sched#1151). This change should be accompanied by an update to RFC 27. Update sched-simple unit test. Fixes flux-framework#5775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: R has to be looked up from the KVS in the
sched.freerequest handler, but now that the job manager caches R, this is an unnecessary extra step.Add R to the
sched.freerequest payload.Note that the
R.schedulingkey is not included. The current design of Fluxion in whichR.schedulingmay contain a voluminous JGF object made caching this part of R impractical.Change libschedutil so that
sched.freemessage handler never looks up R in the kvsRargument to NULLUpdate sched-simple's free callback to unpack R from the message instead of decoding the
Rarugment.Note that Fluxion sets SCHEDUTIL_FREE_NOLOOKUP so it already expects the free callback's R argument to be NULL. Although this change increases the size of
sched.freepayloads with data that Fluxion currently does not use, the ranks in R will be required by Fluxion in the future to identify resource subsets for partial release (flux-framework/flux-sched#1151).This change should be accompanied by an update to RFC 27.
Update sched-simple unit test.
Fixes #5775