libflux: handle flux_respond_error (errnum=0) #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a spot of test coverage and rebased on current master. |
|
I'll go ahead and set MWP on this one. |
Problem: if flux_respond_error() is called with errnum of 0, no response is sent, which can cause hard to diagnose problems. Use EINVAL if errnum is zero. Fixes flux-framework#3036
Problem: flux_respond(3) man page says that errnum must be non-zero but that is no longer the case. Document the fact that EINVAL now is used if errnum is zero.
Problem: there is no test coverage that checks that flux_respond_error() sends an EINVAL response if errnum=0. Add this to response unit test.
Codecov Report
@@ Coverage Diff @@
## master #4427 +/- ##
==========================================
- Coverage 83.33% 83.33% -0.01%
==========================================
Files 396 396
Lines 66769 66771 +2
==========================================
+ Hits 55642 55643 +1
- Misses 11127 11128 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: if
flux_respond_error()is called with errnum of 0, no response is sent, which can cause hard to diagnose problems.Use EINVAL if errnum is zero.
Fixes #3036