Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: fix non-bourne shell test failure #3937

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Nov 3, 2021

Problem: The t3920-running-underflow test failed under non
bourne shell shells.

Solution: Set SHELL to /bin/sh in test to ensure proper
execution.

Fixes #3936

Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! And for being our local tcsh guinea 🐷

Problem: The t3920-running-underflow test failed under non
bourne shell shells.

Solution: Set SHELL to /bin/sh in test to ensure proper
execution.

Fixes flux-framework#3936
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #3937 (f4e2744) into master (643e894) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f4e2744 differs from pull request most recent head dd90262. Consider uploading reports for the commit dd90262 to get more accurate results

@@            Coverage Diff             @@
##           master    #3937      +/-   ##
==========================================
- Coverage   83.52%   83.52%   -0.01%     
==========================================
  Files         357      356       -1     
  Lines       52542    52372     -170     
==========================================
- Hits        43886    43742     -144     
+ Misses       8656     8630      -26     
Impacted Files Coverage Δ
src/modules/job-archive/job-archive.c 59.27% <0.00%> (-0.81%) ⬇️
src/cmd/flux-ping.c 84.45% <0.00%> (-0.68%) ⬇️
src/modules/cron/cron.c 81.77% <0.00%> (-0.48%) ⬇️
src/broker/overlay.c 87.91% <0.00%> (-0.24%) ⬇️
src/broker/state_machine.c 79.71% <0.00%> (-0.16%) ⬇️
src/broker/groups.c
src/broker/broker.c 76.96% <0.00%> (+0.14%) ⬆️
src/common/libsubprocess/local.c 79.65% <0.00%> (+0.34%) ⬆️
src/modules/sched-simple/sched.c 77.91% <0.00%> (+0.99%) ⬆️
src/modules/resource/monitor.c 81.63% <0.00%> (+9.78%) ⬆️

@mergify mergify bot merged commit 35b04c4 into flux-framework:master Nov 4, 2021
@chu11 chu11 deleted the issue3936_t3920 branch November 4, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not ok 20 - t3920-running-underflow.sh
2 participants