Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: add valgrind suppression for libev on aarch64 #3809

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

garlick
Copy link
Member

@garlick garlick commented Aug 1, 2021

Problem: a new valgrind test failure was encountered on aarch64,
Ubuntu 20.04.2 LTS and also the official Jetson Ubuntu 18.04:

==1705645== Syscall param epoll_ctl(event) points to uninitialised byte(s)
==1705645== at 0x4BDFE38: epoll_ctl (syscall-template.S:78)
==1705645== by 0x48B37EF: epoll_modify (ev_epoll.c:96)
==1705645== by 0x48B4F57: fd_reify (ev.c:2166)
==1705645== by 0x48B4F57: ev_run (ev.c:3677)
==1705645== by 0x48B4F57: ev_run (ev.c:3623)
==1705645== by 0x48824FF: flux_reactor_run (reactor.c:126)
==1705645== by 0x1113BF: main (broker.c:449)
==1705645== Address 0x1ffefff22c is on thread 1's stack
==1705645== in frame #1, created by epoll_modify (ev_epoll.c:72)

Since this is apparently internal to libev, add a suppression.

Fixes #3808

Problem: a new valgrind test failure was encountered on aarch64,
Ubuntu 20.04.2 LTS and also the official Jetson Ubuntu 18.04:

==1705645== Syscall param epoll_ctl(event) points to uninitialised byte(s)
==1705645==    at 0x4BDFE38: epoll_ctl (syscall-template.S:78)
==1705645==    by 0x48B37EF: epoll_modify (ev_epoll.c:96)
==1705645==    by 0x48B4F57: fd_reify (ev.c:2166)
==1705645==    by 0x48B4F57: ev_run (ev.c:3677)
==1705645==    by 0x48B4F57: ev_run (ev.c:3623)
==1705645==    by 0x48824FF: flux_reactor_run (reactor.c:126)
==1705645==    by 0x1113BF: main (broker.c:449)
==1705645==  Address 0x1ffefff22c is on thread 1's stack
==1705645==  in frame #1, created by epoll_modify (ev_epoll.c:72)

Since this is apparently internal to libev, add a suppression.

Fixes flux-framework#3808
@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #3809 (2789b59) into master (a3f5f71) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3809      +/-   ##
==========================================
- Coverage   83.35%   83.32%   -0.04%     
==========================================
  Files         348      348              
  Lines       51014    51014              
==========================================
- Hits        42521    42505      -16     
- Misses       8493     8509      +16     
Impacted Files Coverage Δ
src/common/libkvs/kvs_txn_compact.c 71.75% <100.00%> (ø)
src/common/libpmi/simple_client.c 86.33% <0.00%> (-3.28%) ⬇️
src/common/libpmi/pmi.c 91.50% <0.00%> (-1.89%) ⬇️
src/modules/job-archive/job-archive.c 59.27% <0.00%> (-0.81%) ⬇️
src/modules/job-info/guest_watch.c 76.00% <0.00%> (-0.62%) ⬇️
src/broker/module.c 75.94% <0.00%> (-0.51%) ⬇️
src/broker/content-cache.c 82.49% <0.00%> (-0.27%) ⬇️
src/broker/broker.c 76.95% <0.00%> (-0.14%) ⬇️
src/modules/kvs/kvs.c 68.13% <0.00%> (-0.09%) ⬇️
src/common/libsubprocess/local.c 79.65% <0.00%> (+0.34%) ⬆️

Copy link
Member

@chu11 chu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit b37dc40 into flux-framework:master Aug 2, 2021
@garlick garlick deleted the issue_3808 branch August 2, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

t5000-valgrind test fails on Jetson Nano
2 participants