Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor rpc interface cleanup; man pages with tested examples; hooks for extending flux_rpc_t #290

Merged
merged 5 commits into from
Jul 24, 2015

Conversation

garlick
Copy link
Member

@garlick garlick commented Jul 23, 2015

Changed flux_rpc_t typedef to refer to an incomplete struct definition, not a pointer to one. All users updated.

Bug fix: stop the message watcher for an RPC continuation once the RPC is complete.

Add man pages for new RPC usage including examples. Examples are compiled and run as part of sharness tests to make sure they don't fall out of date.

Add some functions to facilitate extending/wrapping flux_rpc_t as discussed in issue #76

const char *flux_rpc_type_get (flux_rpc_t *rpc);
void flux_rpc_type_set (flux_rpc_t *rpc, const char *type);
void *flux_rpc_aux_get (flux_rpc_t *rpc);
void flux_rpc_aux_set (flux_rpc_t *rpc, void *aux, flux_free_f destroy);

@grondo
Copy link
Contributor

grondo commented Jul 23, 2015

Nice touch with the examples that are compiled as part of testing. We should encourage that practice for all examples in documentation.

Looks like recent merge of your other PR means this one needs to be rebased.

garlick added 5 commits July 23, 2015 16:35
Change the typedef of flux_rpc_t to conform to RFC 7 recommendations
that opaque types not obscure the fact that they are a pointer.
Code examples are built as check_PROGRAMS and run as part of
sharness t/t0002-request.t
This will assist with wrapping/extending flux_rpc_t for specific RPC classes.
grondo added a commit that referenced this pull request Jul 24, 2015
minor rpc interface cleanup; man pages with tested examples; hooks for extending flux_rpc_t
@grondo grondo merged commit b2f6e8f into flux-framework:master Jul 24, 2015
@grondo grondo removed the review label Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants