libutil/cleanup: improve out of memory handling, conform to RFC 7 #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: cleanup source module contains minor RFC 7 style inconsistencies, mostly white space. Add space between function and parameter list Remove space between '*' and pointer variable. Start brace on same line as conditional. Move static variable declarations above first function def. Fix typo in comment.
Problem: If malloc fails in cleanup_push_string (), proram will exit, which is probably not ideal. We may want more control over the exit path than that. Replace xstrdup () with strdup () and just skip cleanup if the allocation fails.
Problem: if calloc() fails in cleanup_push(), a segfault will ensue. Don't assign values to allocated struct if calloc fails. Also, if zlist_append() fails, free the allocated struct instead of leaking it.
grondo
force-pushed
the
cleanup_cleanup
branch
from
53a3de1 to
bf4f58a
Compare
|
merci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few style anomalies in the cleanup code, and cleans up out of memory error paths.
Split from #2783 to thin that one down a bit.