-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
begin asciidoc api man pages #273
Conversation
Wow, a lot of work here. Nice. My opinion is that API manpages should not be wired to Good ideas on moving spellcheck around. My suggestion would be to put the script and dictionary under |
Oh test makes good sense. What about a new subcommand like I just remembered that man wants a man3 subdir. I have a hack to symlink doc/cmd to doc/man1. Should we just make the canonical directories man1 and man3? |
We may indeed have an intermittent hang in wreck tests. First build hung for this PR -- I restarted and seems to be ok now |
Maybe the default grace period we just cranked down is too short? |
Could something that exports appropriate MANDIR in a working dir be used instead of I'm fine with (That being said, knowing you are getting the man pages associated with the flux command you are running would be a real nice property. Also, maybe you could expand the command to serve up html pages too
|
OK, I moved the dictionary and spellcheck scripts as discussed, and changed the directories to man1 and man3. It turns out that |
It only took 20m or so to rebase and fix all of it. |
Oh, man. I feel really bad about that. :person_frowning: I will say that this PR is now an example and a shining beacon that will inform the behavior of pull requests for a long time to come. I am showing it to my children now. I shall press the merge button with pleasure! |
This PR adds documentation for most of the functions in src/common/libflux/handle.h.
Here are the misdemeanors in this PR that I am aware of:
a2x
.flux help
. Should they be?$(top_srcdir)/doc/cmd/spellcheck
. Should that go with a shared dictionary in doc/etc or something like that?