kvs: Add src and dst namespace to kvs copy & move #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, hit a failure in t2000-wreck-env it seems all tests passed, but I guess the broker took to long to shut down and it was killed? |
Shouldn't need that one since lookup starts from a specific hash, not from the root of a namespace. |
|
I went ahead and restarted that builder. The failure seems unlikely to be related to this PR. |
Doubt that this has anything to do with these changes. Was gonna restart the builder, but it seems someone beet me to it :-) |
lol, what timing. |
|
I win! |
In several locations, a bitwise OR (|) was accidentally used instead of a logical OR (||).
Create new wrapper function flux_kvs_lookup_ns() to handle lookup with a specific namespace.
Create new wrapper function flux_kvs_commit_ns() to handle commit with a specific namespace.
Add headers to access flux_kvs_lookup_ns() and flux_kvs_commit_ns().
Have flux_kvs_copy() and flux_kvs_move() take namespace parameters for the source & destination keys. This allows copying and moving between different namespaces without need for using the "ns:" prefix.
Add --src-namespace and --dst-namespace options to copy and move commands. This allows users to specify alternate namespaces without using the ns prefix mechanism.
chu11
force-pushed
the
issue1860_part1
branch
from
78a70e8 to
df8a1c3
Compare
|
rebased |
Codecov Report
@@ Coverage Diff @@
## master #1936 +/- ##
==========================================
+ Coverage 80.05% 80.07% +0.01%
==========================================
Files 195 195
Lines 35059 35078 +19
==========================================
+ Hits 28065 28087 +22
+ Misses 6994 6991 -3
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first part of issue #1860. I've elected to make the new functions
flux_kvs_commit_ns()andflux_kvs_lookup_ns()private. The API should have more of these functions (flux_kvs_fence_ns(),flux_kvs_lookupat_ns(), kvsdir, etc.) and tests, but I am leaving that work for another day.