Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis-ci: try harder to fix deploy #1906

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

grondo
Copy link
Contributor

@grondo grondo commented Jan 4, 2019

I apologize, but I put the GitHub deploy into the wrong travis builder (it doesn't run make distcheck, so there was no tarball to deploy).

I've tested this now as best I could on my own branch, and I believe it should be fixed this time.

Really sorry about the extra noise!

Problem: the previous fix for travis-ci auto-deploy was broken
because the deploy was being attempted on a builder that doesn't
run `make distcheck` any more, so there was no tarball to deploy.

Move the deploy to a builder with DISTCHECK=t.
@garlick
Copy link
Member

garlick commented Jan 4, 2019

NP at all! Glad you're working on this one. Will press button once this one passes.

@codecov-io
Copy link

Codecov Report

Merging #1906 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1906      +/-   ##
=========================================
- Coverage   80.14%   80.1%   -0.05%     
=========================================
  Files         196     196              
  Lines       35065   35065              
=========================================
- Hits        28104   28089      -15     
- Misses       6961    6976      +15
Impacted Files Coverage Δ
src/bindings/lua/lua-affinity/lua-affinity.c 95.62% <0%> (-2.19%) ⬇️
src/common/libflux/response.c 81.48% <0%> (-1.24%) ⬇️
src/modules/connector-local/local.c 73.77% <0%> (-1.04%) ⬇️
src/broker/modservice.c 78.84% <0%> (-0.97%) ⬇️
src/modules/kvs/kvs.c 66.56% <0%> (-0.15%) ⬇️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️

@garlick garlick merged commit 0bcf910 into flux-framework:master Jan 4, 2019
@grondo grondo deleted the travis-deploy-oops branch February 8, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants