kvs: add additional tests & comments #1771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hit a #1595 , restart builder |
|
rebased |
Add tests in kvstxn to test number of missing references returned when processing.
|
oops, noticed a typo and an extra excessive test that I removed. already squashed |
|
actually, I'll close this PR ... I'll do this an #1760 in the same pull request. |
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
+ Coverage 79.58% 79.58% +<.01%
==========================================
Files 185 185
Lines 34459 34459
==========================================
+ Hits 27423 27424 +1
+ Misses 7036 7035 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By nothing more than chance was working on adding unit tests to cover #1751 that were not related to #1760. But now that I need to add unit tests to #1760, these changes are actually useful. So trying to sneak these in first.
This is not dependent on #1764, could go in first.