Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update python/lua KVS bindings to not use kvs classic functions #1748

Merged
merged 5 commits into from
Oct 24, 2018
Merged

update python/lua KVS bindings to not use kvs classic functions #1748

merged 5 commits into from
Oct 24, 2018

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Oct 22, 2018

Also fix random trivial things I found along the way.

@codecov-io
Copy link

codecov-io commented Oct 22, 2018 •
edited
Loading

Codecov Report

Merging #1748 into master will decrease coverage by 0.03%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
- Coverage   79.62%   79.59%   -0.04%     
==========================================
  Files         185      185              
  Lines       34451    34459       +8     
==========================================
- Hits        27433    27426       -7     
- Misses       7018     7033      +15
Impacted Files Coverage Δ
src/bindings/lua/kvs-lua.c 73.15% <0%> (-3.07%) ⬇️
src/modules/wreck/wrexecd.c 76.1% <66.66%> (-0.13%) ⬇️
src/modules/barrier/barrier.c 76.55% <0%> (-2.07%) ⬇️
src/common/libflux/response.c 79.62% <0%> (-1.24%) ⬇️
src/bindings/lua/flux-lua.c 82.12% <0%> (-0.7%) ⬇️
src/cmd/flux-module.c 85.28% <0%> (-0.31%) ⬇️
src/modules/connector-local/local.c 74.51% <0%> (+1.35%) ⬆️

@chu11
Copy link
Member Author

chu11 commented Oct 22, 2018

it appears the trivial cleanups I did are not actually covered by any tests, thus the low diff coverage. Should I just remove the trivial cleanups?

@SteVwonder SteVwonder changed the title update python KVS bindings to not use kvs classic functions update python/lua KVS bindings to not use kvs classic functions Oct 23, 2018
@SteVwonder
Copy link
Member

Looks like pylint is not happy with some of the changes.

Should I just remove the trivial cleanups?

It seems wrong to me to not include cleanups to appease the coverage tool. I'm OK with the coverage drop, but I'll defer to others on this.

@garlick
Copy link
Member

garlick commented Oct 23, 2018

It seems wrong to me to not include cleanups to appease the coverage tool. I'm OK with the coverage drop, but I'll defer to others on this.

Yeah, I'm with Stevie.

@chu11 chu11 force-pushed the python_kvs_classic branch from 49035d1 to 95ddec3 Compare October 23, 2018 17:51
@chu11
Copy link
Member Author

chu11 commented Oct 23, 2018

fixed up pylint issues, already squashed patch since it was simple. Also rebased.

@garlick
Copy link
Member

garlick commented Oct 23, 2018

LGTM

@chu11
Copy link
Member Author

chu11 commented Oct 23, 2018

hmmm i guess pylint conventions / warnings also have to be corrected

@chu11 chu11 force-pushed the python_kvs_classic branch from 95ddec3 to 8869baf Compare October 24, 2018 00:05
@chu11
Copy link
Member Author

chu11 commented Oct 24, 2018

fixed warnings / convention complaints. Considered using a property decorator for aux_txn in the flux handle, but it became complicated when trying to load the kvs bindings as well as the core bindings in handle.py so just removed the underscore prefix to aux_txn.

@chu11 chu11 force-pushed the python_kvs_classic branch from 8869baf to e44513e Compare October 24, 2018 00:16
@chu11
Copy link
Member Author

chu11 commented Oct 24, 2018

oops, pushed the wrong tree, trying again

@chu11 chu11 force-pushed the python_kvs_classic branch from e44513e to a05e300 Compare October 24, 2018 00:26
@garlick
Copy link
Member

garlick commented Oct 24, 2018

Maybe an ack from @SteVwonder on the python changes and then this can go in?

@SteVwonder SteVwonder merged commit bd23bac into flux-framework:master Oct 24, 2018
@chu11 chu11 mentioned this pull request Oct 29, 2018
Closed
This was referenced Jan 18, 2019
Closed
Merged
@chu11 chu11 mentioned this pull request Feb 4, 2019
Merged
@chu11 chu11 deleted the python_kvs_classic branch June 5, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chu11 @codecov-io @SteVwonder @garlick