common/subprocess: Do not append _FD to channels #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hit a #1641, restart builder |
|
Looks good, just needs a rebase since #1658 was merged. |
Do not append the string "_FD" to the channel environment variables created for subprocesses. Instead, use the channel name itself. If the caller wishes for the environment variable to have "_FD" at the end, they should name their channel with "_FD" at the end.
chu11
force-pushed
the
issue1331-envname
branch
from
74437cf to
d8bc18a
Compare
|
rebased and re-pushed |
|
hit at #1641, restarted builder |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not append the string "_FD" to the channel environment variables
created for subprocesses. Instead, use the channel name itself.
If the caller wishes for the environment variable to have "_FD"
at the end, they should name their channel with "_FD" at the end.