subprocess: use _exit() in subprocess_child #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Use of exit(3) on fatal errors in subprocess_child() should not be used since the child still has a copy of the parents VM, and thus may inappropriately call atexit or other handlers. Use _exit(2) instead to immediately terminate the forked process on error. Fixes flux-framework#1638
|
LGTM, can merge once travis passes. Just to make sure, there isn't an order to merging given your other PR? |
|
hmm you hit a valgarind error, similar to #1641, but also slightly different. |
|
I restarted the builder that hit the valgrind error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix for #1638 didn't strictly belong with either the travis-ci/testing fixes in #1644, nor the GCC 8 updates in #1642, so I'm including it in its own PR.