Drop jsc rdl_alloc JSC keys #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These keys are no longer used in favor of the "R_lite" key. Adjust the JSC tests. Note that "rdl" key is still kept because there is a chance that it will be used by the scheduler as a stopgap solution to support nested scheduler instantiations.
|
Looks good thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
==========================================
+ Coverage 78.67% 78.72% +0.04%
==========================================
Files 164 164
Lines 30686 30597 -89
==========================================
- Hits 24142 24087 -55
+ Misses 6544 6510 -34
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These keys are no longer used in favor of the "R_lite" key.
Adjust the JSC sharness test and README.md.
Will break flux-sched master until flux-framework/flux-sched#339 is merged.
Issue is discussed at flux-framework/flux-sched#338.
Note that "rdl" key is still kept because there is a chance that it can be used by the scheduler as a stopgap solution to support nested scheduler instantiations.