-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend JSC to add R_lite support #1485
Conversation
Use flux_kvs_txn_put () and flux_kvs_txn_get () as RDL is always a serialized string.
Codecov Report
@@ Coverage Diff @@
## master #1485 +/- ##
==========================================
- Coverage 78.72% 78.66% -0.06%
==========================================
Files 164 164
Lines 30358 30405 +47
==========================================
+ Hits 23900 23919 +19
- Misses 6458 6486 +28
|
Just posted the corresponding flux-sched PR: flux-framework/flux-sched#321 |
@dongahn, this looks like it solves the problem, and I'm glad you added the test. I think there are quite a few issues that shouldn't blow by without comment, such as
However, this code is consistent with hte rest of the library and I think we could merge it as is with the plan to create something new for the new execution system. Is that reasonable? |
That sounds reasonable to me. Thanks @garlick. |
This PR supports the
R_lite
writer PR which I will post soon to flux-sched.Also add some minor fixes along the way:
flux-jstat
command.Add a very simple
R_lite
test to a JSC test.