modules/kvs: fix memory leak in namespace_create() #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: valgrind test fails when private KVS namespace is made part of job setup. Looks like some memory allocated in namespace_create() that was freed in the error path, was not freed in the non-error path. Fix that. Fixes flux-framework#1483
Codecov Report
@@ Coverage Diff @@
## master #1484 +/- ##
==========================================
- Coverage 78.77% 78.73% -0.04%
==========================================
Files 164 164
Lines 30355 30358 +3
==========================================
- Hits 23911 23903 -8
- Misses 6444 6455 +11
|
|
LGTM, sorry for missing this obvious path. |
|
No worries, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: valgrind test fails when private KVS namespace
is made part of job setup.
Looks like some memory allocated in namespace_create()
that was freed in the error path, was not freed in
the non-error path. Fix that.
Fixes #1483