fixes for broken tests, addition to gitignore #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the test for working test_size_large, which tests MIN setting with an invalid assumption that 123 was larger than any likely machine nprocs+1. However, this was not true for large systems with 128 procs for example. Instead test with an obscenely large setting for FLUX_TEST_SIZE_MIN. Fixes flux-framework#1442
Problem: test for `flux-wreck attach --no-follow` has a race condition, since there is no synchronization between when task output makes it to kvs, and the run of `attach --no-follow`. We still want to ensure that attach can print output that has already made it to the kvs, so we don't want to accept only partial output as a sign of success. Fix: retry the `attach --no-follow` in a loop until all data has made it into kvs. Fixes flux-framework#1459
Problem: The test_under_flux() sharness function fails to create a broker.log for the test when the --verbose flag is used. This is counterintuitive. I think this was meant to send dmesg log messages to stderr when --verbose was used. However, this no longer is the case. Additionally, non-verbose mode used the broker's `-q, --quiet` flag, which apparently does nothing. Instead of the current confusing operation, just remove the use of -q, and always write a broker.log file for tests using test_under_flux with log-forward-level=7.
When using test_under_flux a broker.log file is created to capture all log messages into a log file. However, there is no way to preserve this file for successful tests, as other test products can be preserved with --debug. Set the broker.log for tests to only be added to cleanup when --debug has not been used. Fixes flux-framework#1288
Add *.gcda and *.gcno to project .gitignore.
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
- Coverage 78.73% 78.72% -0.01%
==========================================
Files 163 163
Lines 30265 30265
==========================================
- Hits 23828 23827 -1
- Misses 6437 6438 +1
|
Remove reference to broker -q, --quiet flag in usage output for flux-start's `-o` option. This option is no longer supported in the broker.
Don't try to pass '-q' option to flux-broker. The option is no longer valid.
This option does nothing. Remove it to avoid confusion. Fixes flux-framework#1461
Remove the -q, --quiet option from flux-broker.adoc. It is no longer a valid option to the broker.
|
I forgot that the lua tests driver |
|
Thanks - looks good. |
|
Thanks! |
garlick
added a commit
to garlick/flux-sched
that referenced
this pull request
Apr 18, 2018
Problem: test_under_flux() conditionally starts the broker with the -q option, but that option is no longer valid. N.B. flux-broker -q,--quiet was dropped in PR flux-framework/flux-core#1464. flux-sharness.sh has lagged behind the one in flux-core. Copy over the flux-core version.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of minor fixes for a couple broken sharness tests, a fix for the generation of the broker.log from
test_under_fluxand a small addition to.gitignore