kvs: do not generate uuid for commit transactions, use fixed algorithm for 'name' #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice improvement. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1458 +/- ##
==========================================
- Coverage 78.8% 78.73% -0.07%
==========================================
Files 163 163
Lines 30220 30221 +1
==========================================
- Hits 23814 23796 -18
- Misses 6406 6425 +19
|
|
Great! Needs a rebase. |
Remove 'name' from commit RPC and move 'name' generation internally into the kvs module.
Add convenience function that will create a treq data structure, and internally create a name based on a rank and sequence number passed in. Add unit tests appropriately.
For commit transactions, instead of generating a name using an expensive to generate uuid, instead use a simple fixed name involving a flux rank and a per rank sequence number. Fixes flux-framework#1446
|
just repushed |
|
Restarted builder that hung after |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1446, do not generate a uuid for commit transactions, which is expensive. Instead, use a fixed algorithm to generate a name for each transaction, using the rank and sequence number incremented on each rank.
The commit RPC no longer needs to include the "name" field anymore as a result. As the name can be generated within the kvs module.