kvs: don't check namespace if user passes in at reference #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error in which a treeobj was created where a valref raw buffer should have been created.
If the user passed in a root reference, there is no need to check if the namespace the user passed in is valid. Fixes flux-framework#1401
Add tests to check for situations in which root reference is specified by the user, and ensure namespace checks are not done.
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
==========================================
+ Coverage 78.72% 78.74% +0.02%
==========================================
Files 163 163
Lines 30204 30206 +2
==========================================
+ Hits 23777 23787 +10
+ Misses 6427 6419 -8
|
|
Seems reasonable, thanks, |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1401, where on replays namespaces were always checked for validity even if user originally passed in at reference.
At unit tests appropriately.