You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvs_watch is no longer used internally so drop comment
that refers to it.
The returned "jcb" parameter is now a string, so tell
the user to release it with free(), not json_object_put().
Private macros to strcmp a key to a jsc attribute
are probably not adding much to readability.
In an effort to make the code more readable, drop these.
Um, I haven't tested it with sched. I assumed that passing the jsc sharness test was probably good enough for this change set. I did check (with grep) that sched wasn't using the deprecated interfaces.
I have been unable to get sched compiled on ubuntu 17.10 (what I currently have in a vm on my laptop) due to the default libboost version of 1.62. I need to figure out how to downgrade that package I guess...
I have been unable to get sched compiled on ubuntu 17.10 (what I currently have in a vm on my laptop) due to the default libboost version of 1.62. I need to figure out how to downgrade that package I guess...
Yeah... The defects in some of these libboost versions are pretty unfortunate. I didn't have time to look at ways to work around it. For now, though, because JSC won't affect resource-query, you can just comment out the resource in your make file and test your changes with the sched PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are a few simple cleanups for libjsc, peeled off of #1388
The main thing here is dropping the deprecated (and unused) API functions. The rest is minor.