kvs: refactor with internal kvsroot file #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit_mgr_iter_not_ready_fences() should clean up the remove list on a callback error.
|
Looks like a good direction. I restarted a travis build that had stalled for no apparent reason. |
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
========================================
Coverage ? 78.2%
========================================
Files ? 156
Lines ? 28269
Branches ? 0
========================================
Hits ? 22107
Misses ? 6162
Partials ? 0
|
|
ok, let me add documentation & unit tests, then this should be all good to go. |
Move destroy_root(), remove_root(), create_root(), lookup_root(), and lookup_root_safe() over to new files. Adjust code appropriately given move.
Prefix kvsroot to kvsroot internal API functions, adjusting functions names appropriately and updating callers.
Adjust core kvs callers that iterate manually through the roothash.
Adjust/change function names for abstraction creation.
Variables previously passed to kvsroot_mgr_create_root(), now handled by the manager itself in kvsroot_mgr_create().
Allow removal of entries from kvsroot roothash while iterating by abstracting away remove logic from the user.
chu11
force-pushed
the
kvsrootrefactor
branch
from
aa57717 to
0f9ec32
Compare
|
added a few header comments in |
|
Looks good @chu11 - no coverage report here (?) but it was +0.003% in the last report and it seems it can't help but have gone up from there with the new tests, so I'm good to merge if you're ready. |
|
yup, all done. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch isn't ready for merging (need to add documentation & unit tests) but thought I'd push to ask for comments.
I had originally gone down the path of abstracting the kvsroot way more than what is done in this PR. But as I was refactoring, it became clear abstracting
struct kvsrootwas creating a complex and probably unnecessary level of abstraction.For example, abstracting
start_root_remove()inkvs.c. It's a good idea to want to abstract it away, but its difficult to abstract away the cleanup of fences sitting in the commit manager. Do we ask the user to pass in a callback function to deal with the cleanup of fences? We aren't abstracting very well if we're asking the user for that.I briefly considered moving everything related to commits into
kvsroot.c, but seemed like too much. So I think other refactoring needs to be done before moving onto refactoring kvsroot more. Some thoughts for the future.fence.[ch]. Perhaps everything should be collapsed into the commit manager in some way.