kvs test cleanup #1313

chu11 · 2018-01-03T22:34:34Z

Some simple kvs test cleanup I wanted to do. Mostly put some common functions into kvs/kvs-helper.sh, but some tiny things beyond that too.

Rename wait_watch_current() to wait_watch_file() and take filename as argument.

Make loop iteration configurable via new KVS_WAIT_ITERS variable.

coveralls · 2018-01-03T23:09:41Z

Coverage decreased (-0.5%) to 78.088% when pulling 3116a81 on chu11:kvscleanup8 into d29b0cd on flux-framework:master.

codecov-io · 2018-01-03T23:35:36Z

Codecov Report

Merging #1313 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
- Coverage   78.24%   78.23%   -0.02%     
==========================================
  Files         154      154              
  Lines       28100    28100              
==========================================
- Hits        21987    21984       -3     
- Misses       6113     6116       +3

Impacted Files	Coverage Δ
src/common/libkvs/kvs_watch.c	`87.66% <0%> (-0.89%)`	⬇️
src/common/libutil/base64.c	`95.07% <0%> (-0.71%)`	⬇️
src/broker/overlay.c	`73.88% <0%> (-0.64%)`	⬇️
src/modules/connector-local/local.c	`74.38% <0%> (-0.21%)`	⬇️
src/common/libflux/message.c	`81.6% <0%> (+0.11%)`	⬆️
src/common/libflux/handle.c	`83.91% <0%> (+0.24%)`	⬆️
src/common/libflux/request.c	`89.74% <0%> (+1.28%)`	⬆️

chu11 · 2018-01-03T23:35:41Z

oops, bourne shell uses . and not source. Re-pushed with fixes.

coveralls · 2018-01-04T00:04:13Z

Coverage decreased (-0.01%) to 78.562% when pulling b380a48 on chu11:kvscleanup8 into d29b0cd on flux-framework:master.

Move helper functions into new kvs/kvs-helper.sh file.

For consistency, rename wait_watch_namespace_put().

Use in t1004-kvs-namespace.t to cleanup lines of code.

chu11 · 2018-01-04T00:37:10Z

oops, forgot to add helper file to dist. Re-pushed again.

chu11 · 2018-01-04T06:41:55Z

Hit #731, restarted a builder

FAIL: t0016-cron-faketime.t 3 - flux-cron tab works for set minute

coveralls · 2018-01-04T06:54:04Z

Coverage decreased (-0.01%) to 78.558% when pulling 9475591 on chu11:kvscleanup8 into d29b0cd on flux-framework:master.

chu11 · 2018-01-04T07:15:42Z

noticed a minor issue with a comment, repushed

coveralls · 2018-01-04T07:41:38Z

Coverage remained the same at 78.572% when pulling cf3c416 on chu11:kvscleanup8 into d29b0cd on flux-framework:master.

garlick · 2018-01-04T18:08:28Z

This looks good to me. If you're done tweaking it, I vote we merge.

grondo · 2018-01-04T18:24:45Z

I'm not commenting on this PR specifically, however if someone does more cleanup in the future, you could see if the busywaiting in wait_watch_file() could be replaced with t/scripts/waitfile.lua which uses libev statwatcher to more efficiently wait for a line in a file to match a pattern.

(I didn't look closely at what wait_watch_file actually does so I apologize in advance if the waitfile helper script doesn't apply here)

Use KVS_WAIT_ITERS instead of hard coding 50. Call wait_watch_put() to remove duplicate code. General code cleanup.

Adjust t1000-kvs and t1004-kvs-namespace accordingly.

chu11 · 2018-01-04T18:58:14Z

@garlick i thought of one extra cleanup this morning, so I just pushed that. Otherwise, it's good to go.

chu11 · 2018-01-04T18:59:31Z

@grondo I wasn't aware of the waitfile.lua script, but it seems (glossing over the help comments) like it could probably work. Will have to investigate in the future.

coveralls · 2018-01-04T19:22:34Z

Coverage decreased (-0.01%) to 78.562% when pulling 15b4363 on chu11:kvscleanup8 into d29b0cd on flux-framework:master.

garlick · 2018-01-04T20:38:10Z

Hmm, any idea why that last change dropped the project coverage into the red? Did something stop running I wonder?

grondo · 2018-01-04T21:09:13Z

Hmm, any idea why that last change dropped the project coverage into the red? Did something stop running I wonder?

The coverage only changed -0.02% which is negligible (and probably caused by coverage "noise" that I don't quite understand yet). Codecov should have some tunable that indicates only a drop in coverage of X% should turn the report red (I thought we'd set that already)

garlick · 2018-01-04T21:18:55Z

Oh right, I guess that is not anything to worry about. I'll go ahead and merge.

chu11 added 2 commits January 2, 2018 17:17

t/t1002-kvs-watch.t: Minor function refactor

94983b6

Rename wait_watch_current() to wait_watch_file() and take filename as argument.

t/t1002-kvs-watch.t: Minor code cleanup

c045c78

Make loop iteration configurable via new KVS_WAIT_ITERS variable.

chu11 force-pushed the kvscleanup8 branch from 3116a81 to b380a48 Compare January 3, 2018 23:35

chu11 added 4 commits January 3, 2018 16:36

t/t1002-kvs-watch.t: Move helper functions

bb4c3cd

Move helper functions into new kvs/kvs-helper.sh file.

t/t1004-kvs-namespace.t: Use kvs helper functions

4cc1478

t/t1004-kvs-namespace.t: Rename function

619bdb8

For consistency, rename wait_watch_namespace_put().

t/kvs/kvs-helper.sh: Add loophandlereturn()

300b8de

Use in t1004-kvs-namespace.t to cleanup lines of code.

chu11 force-pushed the kvscleanup8 branch from b380a48 to 9475591 Compare January 4, 2018 00:36

chu11 force-pushed the kvscleanup8 branch from 9475591 to cf3c416 Compare January 4, 2018 07:14

chu11 added 2 commits January 4, 2018 10:54

t/t1004-kvs-namespace.t: Minor cleanup

5d155cb

Use KVS_WAIT_ITERS instead of hard coding 50. Call wait_watch_put() to remove duplicate code. General code cleanup.

t/kvs: Add test_kvs_key to kvs helper

15b4363

Adjust t1000-kvs and t1004-kvs-namespace accordingly.

chu11 force-pushed the kvscleanup8 branch from cf3c416 to 15b4363 Compare January 4, 2018 18:57

garlick merged commit 6cd7cf7 into flux-framework:master Jan 4, 2018

grondo mentioned this pull request May 10, 2018

0.9.0 Release #1479

Closed

chu11 deleted the kvscleanup8 branch June 5, 2021 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kvs test cleanup #1313

kvs test cleanup #1313

chu11 commented Jan 3, 2018

coveralls commented Jan 3, 2018

codecov-io commented Jan 3, 2018 •

edited

Loading

chu11 commented Jan 3, 2018

coveralls commented Jan 4, 2018

chu11 commented Jan 4, 2018

chu11 commented Jan 4, 2018

coveralls commented Jan 4, 2018

chu11 commented Jan 4, 2018

coveralls commented Jan 4, 2018

garlick commented Jan 4, 2018

grondo commented Jan 4, 2018

chu11 commented Jan 4, 2018

chu11 commented Jan 4, 2018

coveralls commented Jan 4, 2018

garlick commented Jan 4, 2018

grondo commented Jan 4, 2018

garlick commented Jan 4, 2018

kvs test cleanup #1313

kvs test cleanup #1313

Conversation

chu11 commented Jan 3, 2018

coveralls commented Jan 3, 2018

codecov-io commented Jan 3, 2018 • edited Loading

Codecov Report

chu11 commented Jan 3, 2018

coveralls commented Jan 4, 2018

chu11 commented Jan 4, 2018

chu11 commented Jan 4, 2018

coveralls commented Jan 4, 2018

chu11 commented Jan 4, 2018

coveralls commented Jan 4, 2018

garlick commented Jan 4, 2018

grondo commented Jan 4, 2018

chu11 commented Jan 4, 2018

chu11 commented Jan 4, 2018

coveralls commented Jan 4, 2018

garlick commented Jan 4, 2018

grondo commented Jan 4, 2018

garlick commented Jan 4, 2018

codecov-io commented Jan 3, 2018 •

edited

Loading