Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: add more kvs stats #1310

Merged
merged 3 commits into from
Dec 15, 2017
Merged

kvs: add more kvs stats #1310

merged 3 commits into from
Dec 15, 2017

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Dec 15, 2017

This PR is peeled off from my namespace remove work. It feels semi-independent of the larger work and decided it may be useful to put it off in its own PR.

This is independent of #1309 .

Support commit_mgr_fences_count() and commit_mgr_ready_commit_count()
to retrieve fences and ready commit counts.  Will be needed for
namespace removal and general stat checking.

Add new unit tests appropriately.
Get commit mgr fence count and ready commit count.
@codecov-io
Copy link

codecov-io commented Dec 15, 2017

Codecov Report

Merging #1310 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
- Coverage   78.25%   78.22%   -0.03%     
==========================================
  Files         154      154              
  Lines       27937    27941       +4     
==========================================
- Hits        21862    21857       -5     
- Misses       6075     6084       +9
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 65.57% <100%> (-0.21%) ⬇️
src/modules/kvs/commit.c 78.01% <100%> (+0.2%) ⬆️
src/common/libflux/mrpc.c 85.49% <0%> (-1.18%) ⬇️
src/common/libflux/response.c 83.73% <0%> (-0.82%) ⬇️
src/broker/overlay.c 73.88% <0%> (-0.32%) ⬇️
src/common/libflux/message.c 81.25% <0%> (-0.24%) ⬇️

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 78.553% when pulling 6cdb269 on chu11:kvsmorestats into fb37531 on flux-framework:master.

@garlick
Copy link
Member

garlick commented Dec 15, 2017

Looks good - thanks!

@garlick garlick merged commit 72d3059 into flux-framework:master Dec 15, 2017
@grondo grondo mentioned this pull request May 10, 2018
@chu11 chu11 deleted the kvsmorestats branch June 5, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants