kvs: [cleanup] fix blobref_t typedef and unfortunate variable names #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a fixed length array that can hold any blobref. Use it in blobref unit test.
Eliminate href_t typedef and switch users to blobref_t. Drop types.h which only contained that one typedef.
Problem: treeobj_hash() no longer has users, except in tests. Drop the function from the treeobj.c and replicate it in the KVS lookup and commit unit tests. Update treeobj unit tests.
Use blobref_t, a fixed length string type, as the blobref param to blobref_hash() blobref_hashtostr() blobref_strtohash() and drop the size parameter since the size is implicit in the type. Update various users and tests.
Problem: the variable "hp is used extensively to refer to an internal KVS cache entry, which is not intuitive. Change all occurrences of the variable "hp" to "entry", when it refers to a cache entry. Fixes flux-framework#1222
|
Nothing stood out to me. I'm glad to see |
|
Thanks - I'm good with merging this if you are. |
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
==========================================
- Coverage 77.95% 77.95% -0.01%
==========================================
Files 154 154
Lines 29097 29086 -11
==========================================
- Hits 22684 22675 -9
+ Misses 6413 6411 -2
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly cosmetic. As noted in #1222 the use of the "hp" variable name to refer to an internal KVS cache entry is ubiquitous and confusing. Change it to "entry".
Drop the
href_ttypedef in the KVS and create an identical definition calledblobref_tover in libutil/blobref.h. Change some of the blobref functions to accept the fixed length char array rather than char pointer and length to make less verbose to use by its primary user in the KVS.Drop the
treeobj_hash()function which no longer has any users (replicating it in unit tests that need it, and changing it to use a blobref_t argument).