kvs: additional cleanup and refactoring #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function now takes const void ** isntead of just void **. Adjust callers appropriately.
Add new function to hash tree objects. Add unit tests appropriately.
Replace with call to treeobj_hash().
With RFC11 changes, we always know the data in a treeobj val object is a base64 encoded string. Therefore, we do not need to call kvs_util_json_encoded_size to get the encoded size. We just need to call strlen() on the string value.
With recent changes, kvs_util_json_dumps() and kvs_util_json_encoded_size() are no longer used, so remove them and associated unit tests. Also remove now unnecessary header includes.
Codecov Report
@@ Coverage Diff @@
## master #1273 +/- ##
==========================================
+ Coverage 77.87% 77.88% +0.01%
==========================================
Files 154 154
Lines 29138 29124 -14
==========================================
- Hits 22691 22684 -7
+ Misses 6447 6440 -7
|
|
Looks great, thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part three of issue #1264. This is the easy set of cleanups/refactoring. Don't think anything here will be considered too fascinating.
Only thing to note is the old
kvs_util_json_has()function took ahref_t, buttreeobj_hash()takes achar *and int. It's b/chref_tis only defined for the KVS server right now. Considered removinghref_tand generalizing it withchar ref[NUM], but I elected not too.