kvs: refactor server cache functions #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add function to decode treeobj's with buffers without NUL terminating character.
Refactor cache_entry_get_json() and cache_entry_set_json() to cache_entry_get_treeobj() and cache_entry_set_treeobj(), as the cache no longer stores plain old json. Internally, adjust code, such as using treeobj specific functions for encoding and decoding. Update unit tests appropriately and add new tests as needed. Update callers as well.
The function was more widely used before, but is now only used in two locations. Remove function and replace with calls to other functions. Remove unit tests for cache_lookup_and_get_treeobj(). Adjust callers appropriately.
|
LGTM! |
Codecov Report
@@ Coverage Diff @@
## master #1268 +/- ##
==========================================
+ Coverage 77.87% 77.87% +<.01%
==========================================
Files 154 154
Lines 29093 29104 +11
==========================================
+ Hits 22656 22665 +9
- Misses 6437 6439 +2
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part one if issue #1264. A minor refactor, renaming several "json" functions to "treeobj" and adjusting the logic accordingly.
I'm splitting it up b/c the second half of #1264 is growing and seems particularly distinct.