-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: drop man page stub that cannot be generated #1258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok, that will work for now I guess. I guess we should open a longer term issue to deal with the missing manpage? |
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
- Coverage 77.89% 77.88% -0.02%
==========================================
Files 154 154
Lines 28934 28934
==========================================
- Hits 22537 22534 -3
- Misses 6397 6400 +3
|
Apparently we've asked asciidoc to generate one too many man page stubs from flux_kvS_txn_create.adoc. Since it's not generated, make install fails. For now, drop the stub from the Makefile.am so make install can work. Fixes flux-framework#1256
Restarted one builder that failed here:
that might be a new one but shouldn't be related to this PR. |
Here's full output:
|
Thanks. I restarted another one that hung during setup. |
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we've asked asciidoc to generate one too many
man page stubs from flux_kvs_txn_create.adoc.
Since it's not generated, make install fails. For now,
drop the stub from the Makefile.am so make install can work.
Fixes #1256