build: actually disable pylint by default #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit bd4fee8 the pylint check was accidently left enabled by default. The intent was to have the default be *disabled* and only run pylint on --enable-pylint.
|
restarted a builder stuck at the cron test. I'm sorry I didn't catch that when I reviewed it and pushed the button! |
|
I did verify this time that pylint is running in the one builder and not in the others. Probably no need to wait until that builder finishes. Merging. |
|
Oh except gray button :-) |
Codecov Report
@@ Coverage Diff @@
## master #1255 +/- ##
==========================================
+ Coverage 77.88% 77.92% +0.04%
==========================================
Files 154 154
Lines 28934 28934
==========================================
+ Hits 22534 22548 +14
+ Misses 6400 6386 -14
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit bd4fee8 the pylint check
was accidently left enabled by default. The intent was to have the
default be disabled and only run pylint on --enable-pylint.
Sorry! Not sure how that slipped through (I promise I tested functionality several times) 😢