build: only set warning flags for GNU and Clang #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import AX_COMPILER_VENDOR autoconf-archive macro and use the discovered vendor to determine whether to set WARNING_CFLAGS and WARNING_CXXFLAGS instead of using $GCC = "yes". Turns out that $GCC is set to "yes" whenever __GNUC__ is defined by the compiler, and this doesn't imply strict compatibility with gcc. Fixes flux-framework#1251
|
restarted one travis builder that hung in the cron sharness test |
|
Restarted again - this time hung very early in environment setup. |
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
- Coverage 77.9% 77.88% -0.03%
==========================================
Files 154 154
Lines 28903 28903
==========================================
- Hits 22518 22510 -8
- Misses 6385 6393 +8
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import AX_COMPILER_VENDOR autoconf-archive macro and use the
discovered vendor to determine whether to set WARNING_CFLAGS and
WARNING_CXXFLAGS instead of using $GCC = "yes". Turns out that $GCC is
set to "yes" whenever GNUC is defined by the compiler, and this
doesn't imply strict compatibility with gcc.
Fixes #1251