kvs: Misc cleanup & bug fixes #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #1244 +/- ##
==========================================
+ Coverage 77.98% 78.06% +0.08%
==========================================
Files 154 154
Lines 28961 28964 +3
==========================================
+ Hits 22584 22610 +26
+ Misses 6377 6354 -23
|
|
bad coverage on diff, unsurprising given hard to reach error paths. hit two write errors on builds and a hang, unclear when/how builder hung. Restarting. |
Remove no longer relevant comment about synchronous loads. Synchronous loads were removed in commit 19e1fb8.
On cache_entry_create_json() error, we should not return to the caller. Instead we should fallthrough and still call setroot() below.
Handle both raw and json cache data when cleaning up in commit_cleanup_dirty_cache_entry().
|
Changes Unknown when pulling df5f572 on chu11:misccleanup11 into ** on flux-framework:master**. |
|
rebased and re-pushed, couple of builds had write-errors, restarted them and seems everything has passed now |
|
Great - merging. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spliced out of a bigger PR for #1239. Nothing too exciting.