modules/kvs: Replace EPERM w/ ENOTRECOVERABLE #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously EPERM was generally used as the errno to signify that the state without the KVS was inconsistent/illogical (e.g. a dirref points to a val object). To remove confusion that a potential security issue is in play, change the errno from EPERM to ENOTRECOVERABLE. Update unit tests appropriately. Fixes flux-framework#1228
Codecov Report
@@ Coverage Diff @@
## master #1242 +/- ##
==========================================
+ Coverage 78.08% 78.08% +<.01%
==========================================
Files 154 154
Lines 28812 28812
==========================================
+ Hits 22497 22498 +1
+ Misses 6315 6314 -1
|
|
coverage diff is unsurprisingly low, as many "impossible" paths are missed |
|
Looks good, thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously EPERM was generally used as the errno to signify that
the state without the KVS was inconsistent/illogical (e.g. a
dirref points to a val object). To remove confusion that a
potential security issue is in play, change the errno from EPERM
to ENOTRECOVERABLE.
Update unit tests appropriately.
Fixes #1228